Apply cross-validation settings consistently - #1130

Clear random_state when disabling shuffle

When a within-session evaluation has random_state set and supplies cv_kwargs={"shuffle": False}, this merge retains the evaluation's non-None random state while overriding only shuffle. WithinSessionSplitter.__init__ then raises ValueError("random_state should be None when shuffle is False"), so the newly supported shuffle override cannot be used with an otherwise valid seeded evaluation. The identical merge in WithinSubjectEvaluation._create_splitter has the same failure; omit the inherited seed when the effective shuffle setting is false.

Useful? React with 👍 / 👎.

Preserve defaults for CV constructors accepting kwargs

When a custom cross-validator constructor accepts forwarded options through **kwargs rather than naming every parameter, this filter incorrectly treats all defaults as incompatible. For example, a GroupKFold subclass with __init__(self, **kwargs) can accept n_splits, but CrossSubjectEvaluation(n_splits=3, cv_class=Subclass) drops that value here and silently uses the subclass's underlying default fold count instead. Detect a variadic keyword parameter and retain compatible defaults in that case.

Useful? React with 👍 / 👎.